2011/2/1 Hitoshi Harada <umi.tan...@gmail.com>: > 2011/2/1 Tom Lane <t...@sss.pgh.pa.us>: >> Hitoshi Harada <umi.tan...@gmail.com> writes: >>> Finally I concluded the concern Itagaki-san raised can be solved by >>> adding code that restores client_encoding in copy_in_error_callback. >> >> It might happen to work today (or at least in the scenarios you tested), >> but it seems fragile as can be. > > Although I thought its fragile-ness was acceptable to avoid making the > patch too complex, I agree with you. > The third patch is attached, modifying mb routines so that they can > receive conversion procedures as FmgrInof * and save the function > pointer in CopyState. > I tested it with encoding option and could not see performance slowdown. >
Hmm, sorry, the patch was wrong. Correct version is attached. Regards, -- Hitoshi Harada
copy_encoding.v4.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
