On 07.03.2011 14:35, Fujii Masao wrote:
Comments:+ if (!list_member_int(expectedTLIs, + (int) recoveryTargetTLI)) + ereport(LOG, + (errmsg("new timeline %u is not a child of database system timeline %u", We should check whether recoveryTargetTLI is a member of newExpectedTLIs instead of expectedTLIs?
Thanks, fixed.
+ /* Switch target */ + recoveryTargetTLI = newtarget; + expectedTLIs = newExpectedTLIs; Before "expectedTLIs = newExpectedTLIs", we should call list_free_deep(expectedTLIs)? It's an integer list so list_free(expectedTLIs) is enough, and I doubt that leakage will ever be a problem in practice, but in principle you're right.True. But I think that it's good habit to fix a leakage no matter how small it's.
Ah, thanks for the reminder. Added that and committed. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
