On Fri, Mar 11, 2011 at 12:50 PM, Bruce Momjian <br...@momjian.us> wrote: > It has bothered me that many of our time routines use special magic > constants for time values, e.g. 24, 12, 60, etc. > > The attached patch changes these magic constants to macros to clarify > the code. I would like to apply this for 9.1 as a cleanup.
The context diffs show off some references to 1901 and 2038... Here's a *possible* extension to this... -- http://linuxfinances.info/info/linuxdistributions.html
diff --git a/src/backend/utils/adt/nabstime.c b/src/backend/utils/adt/nabstime.c index 0e25c5f..3cf4166 100644 --- a/src/backend/utils/adt/nabstime.c +++ b/src/backend/utils/adt/nabstime.c @@ -178,7 +178,7 @@ tm2abstime(struct pg_tm * tm, int tz) AbsoluteTime sec; /* validate, before going out of range on some members */ - if (tm->tm_year < 1901 || tm->tm_year > 2038 || + if (tm->tm_year < UTIME_MINYEAR || tm->tm_year > UTIME_MAXYEAR || tm->tm_mon < 1 || tm->tm_mon > 12 || tm->tm_mday < 1 || tm->tm_mday > 31 || tm->tm_hour < 0 ||
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
