On Thu, Mar 24, 2011 at 8:34 PM, Simon Riggs <si...@2ndquadrant.com> wrote: > On Thu, Mar 24, 2011 at 11:17 AM, Fujii Masao <masao.fu...@gmail.com> wrote: >> On Wed, Mar 23, 2011 at 5:53 PM, Fujii Masao <masao.fu...@gmail.com> wrote: >>>>> Do you still want to work up a patch for this? If so, I can review. >>> >>> Sure. Will do. >> >> The attached patch allows standby servers to connect during smart shutdown >> in order to wake up backends waiting for sync rep. > > I think that is possibly OK, but the big problem is the lack of a > clear set of comments about how the states are supposed to interact > that allow these changes to be validated. > > That state isn't down to you, but I think we need that clear so this > change is more obviously correct than it is now.
src/backend/replication/README needs to be updated to make that clear? Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
