On Sun, 3 Apr 2011 10:51:04 +0900 Shigeru Hanada <[email protected]> wrote: > 2011/4/2 Robert Haas <[email protected]>: > > On Fri, Apr 1, 2011 at 11:57 AM, Thom Brown <[email protected]> wrote: > >> Should we also have support for comments on user mappings? > > > > Oh, bugger. Yeah, probably. > > I'd work on this, if taking some days is OK.
I've worked on this for a while and found some debatable points. 1) Who can comment on a user mapping? Basically only the owner can comment on a object, but user mappings don't have owner. So following rules for ALTER/DROP seems good because they are similarly allowed to only owner. In addition to server's owner, a user can perform ALTER/DROP USER MAPPING if target mapping is his own user's and USAGE privilege on the server has been granted. This means that mappings for PUBLIC can be commented by only server's owner. Is this spec reasonable? 2) How to specify user name of the target mapping ALTER/DROP USER MAPPING also accept USER and CURRENT_USER as current user. This syntax seems suitable for COMMENT ON USER MAPPING too for consistency and usability. 3) Omitting ACL framework support ISTM that full-support of ACL framework is not necessary for USER MAPPING because USER MAPPING has no GRANT/REVOKE statements. COMMENT ON USER MAPPING patch works fine, but some oversight might be here. Please see attached patches for details. Sorry for long patch names, I generated these patches with git format-patch. And, attached test_user_mapping_comments.sql is a script which I've used to test patches locally. Regards, -- Shigeru Hanada
0001-Implement-COMMENT-ON-USER-MAPPING.patch
Description: Binary data
0002-Add-regression-tests-for-COMMENT-ON-USER-MAPPING.patch
Description: Binary data
0003-Document-about-COMMENT-ON-USER-MAPPING.patch
Description: Binary data
0004-Fix-pg_dump-to-dump-COMMENT-ON-USER-MAPPING-statemen.patch
Description: Binary data
0005-Fix-psql-to-complete-COMMENT-ON-USER-MAPPING-stateme.patch
Description: Binary data
test_user_mapping_comments.sql
Description: Binary data
-- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
