On Sat, Apr 16, 2011 at 11:52:47AM -0400, Tom Lane wrote: > Why in the world is reindex_relation defined like this? > > #define REINDEX_CHECK_CONSTRAINTS 0x1 > #define REINDEX_SUPPRESS_INDEX_USE 0x2 > extern bool reindex_relation(Oid relid, bool toast_too, int flags); > > Seems like a rational design would have folded toast_too in as another > flag bit, instead of keeping it a separate argument.
`relid' and `toast_to' constitute the direct object, and `flags' are adverbs. (Not sure if just made that up or actually rationalized it that way at the time.) No objection to changing it. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
