On 04/20/2011 01:10 PM, Tom Lane wrote:
Aidan Van Dyk<ai...@highrise.ca> writes:Since the general form seems to be to declare things as: typedef struct foo { ... } foo; Is there any reason why we see any struct foo in the sources other than in the typedef line?It gives an escape hatch in case you need a forward reference to the struct, ie you can do "struct foo *" even before this. But I agree that 90% of those struct tags are useless, and so the habit of tagging every typedef this way is mostly legacy.
Yeah, I think it would be reasonable to remove lots of them, especially in argument lists where I think they're a bit ugly anyway.
I'm not sure if now is a good time to be doing that sort of cleanup - maybe we should just add the typedefs we think we're missing to the typedefs list and try another pgindent run, and then make these changes early in 9.2 dev cycle.
cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
