Marko Kreen <mark...@gmail.com> writes:
> On Thu, Jun 2, 2011 at 7:20 PM, Andrew Dunstan <and...@dunslane.net> wrote:
>> Then maybe we need to use "#ifndef WIN32" in those places. That's what we do
>> for similar cases.

> No, that would be a bad idea - uglifies code for no good reason.

> The function is referenced undef IS_AF_UNIX() check, so it would
> not be run anyway.  Even if it would run somehow, there is only
> 2 lines to return ENOSYS.

Yeah, but not compiling thirty lines in fe-connect.c is worthwhile.

The auth_peer code in the backend is #ifdef HAVE_UNIX_SOCKETS, and
I see no reason why this chunk in libpq shouldn't be as well.

                        regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to