Robert Haas <[email protected]> wrote: > There turned out to be a little bit of further subtlety to this, > but it seems to work. Patch attached. Stylistic question: Why is stateP->hasMessages set to false in one place and FALSE and TRUE in others? It seems like it would be less confusing to be consistent. A quick count of the usage of both forms in the PostgreSQL source codes shows the lowercase is used about 10 times more often: kgrittn@kgrittn-desktop:~/git/postgresql/kgrittn$ find -name '*.h' -or -name '*.c' | egrep -v '/tmp_check/' | xargs cat | egrep -c '\b(FALSE|TRUE)\b' 1670 kgrittn@kgrittn-desktop:~/git/postgresql/kgrittn$ find -name '*.h' -or -name '*.c' | egrep -v '/tmp_check/' | xargs cat | egrep -c '\b(false|true)\b' 17349 -Kevin
-- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
