On Tue, Sep 06, 2011 at 03:00:42PM -0400, Tom Lane wrote: > Noah Misch <n...@leadboat.com> writes: > > On Sat, Mar 12, 2011 at 12:44:29PM -0500, Tom Lane wrote: > >> I wonder whether we should instead fix this by copying the correct tuple > >> length. > > > Seems like a step in the wrong direction. We only use typlen and typbyval > > beyond the immediate context. > > Well, the whole point of exposing the pg_type tuple is to avoid making > assumptions about what parts of it the type-specific analyze routine > will wish to look at. If anything we ought to move in the direction of > allowing the non-fixed fields to be accessible too. I didn't do that, > since it would imply an ABI change (to add a HeapTuple field to > VacAttrStats) and would therefore not be back-patchable. But I did > change the code to use SearchSysCacheCopy, which fixes this bug and > is readily extensible if we do decide to add such a field later.
That is a cleaner approach. Thanks. -- Noah Misch http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
