On 26 September 2011 04:46, Robert Haas <[email protected]> wrote: > I don't want to take time to review this in detail right now, because > I don't think it would be fair to put this ahead of things that were > submitted for the current CommitFest, but I'm impressed.
Thank you. Now that I think about it, the if statement that determines if the int4 specialisation will be used may be okay - it sort of documents the conditions under which the int4 specialisation should be used with reference to how the "else" generic case actually works, which is perhaps no bad thing. I now realise that I should be using constants from fmgroids.h though. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
