Tom Lane wrote: > Hiroshi Inoue <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> Actually, your trial required column dropped-ness to be checked in > >> many more places than the proposed approach does. > > > Have you ever really checked my trial implementation ? > > Well, I've certainly stumbled over it in places like relcache.c > and preptlist.c, which IMHO should not have to know about this... > and I have little confidence that there are not more places that > would have needed fixes if the change had gotten any wide use. > You were essentially assuming that it was okay for pg_attribute.attnum > to not agree with indexes into tuple descriptors, which seems very > shaky to me.
Isn't it only the dropped column that doesn't agree with the descriptor. The kept columns retain the same numbering, and a NULL sits in the dropped spot, right? -- Bruce Momjian | http://candle.pha.pa.us [EMAIL PROTECTED] | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026 ---------------------------(end of broadcast)--------------------------- TIP 3: if posting/reading through Usenet, please send an appropriate subscribe-nomail command to [EMAIL PROTECTED] so that your message can get through to the mailing list cleanly
