On Thu, Sep 29, 2011 at 10:52 AM, Gurjeet Singh <singh.gurj...@gmail.com> wrote: > On Thu, Sep 29, 2011 at 1:11 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> >> Gurjeet Singh <singh.gurj...@gmail.com> writes: >> > I noticed that the savepointLevel member of TransactionStateData struct >> > is >> > initialized to 0 from TopTransactionStateData, and never incremented or >> > decremented afterwards. >> >> > Since this is a file-local struct I think we can simply get rid of all >> > usages of this without any risk. >> >> ISTM you have detected a bug, not just dead code that should be removed. >> Surely those tests that throw error on savepointLevel change were >> meant to do something important? > > That's surprising for dead-code removal! > > Not sure which failures you're pointing to. `make check` before and after > the patch on master says 'All 126 tests passed.' >
I think Tom is talking about the test in the code and not a regression test itself. Looking at the archives and git log, it seems though that we never completed this feature and the code was always dead since its inception. http://www.mail-archive.com/pgsql-hackers@postgresql.org/msg48321.html Thanks, Pavan -- Pavan Deolasee EnterpriseDB http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
