On Wed, Nov 2, 2011 at 14:33, Simon Riggs <si...@2ndquadrant.com> wrote: > On Wed, Nov 2, 2011 at 1:14 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Wed, Nov 2, 2011 at 4:44 AM, Simon Riggs <si...@2ndquadrant.com> wrote: >>> Patch removes stuff related to "startup process" and creates files >>> under src/$DIR/postmaster for this code. >>> >>> This makes startup process look more like bgwriter, walwriter etc.. >> >> In general, +1. > > Thanks for the review. > >> But I don't think we want duplicate function prototypes for the same >> functions, so -1 for this hunk: >> >> + /* in xlog.c */ >> + extern void WakeupRecovery(void); >> + extern void StartupXLOG(void); >> >> The existing prototypes in xlog.h seem like they should be just fine. > > That was to avoid having startup.c include xlog.h, which it doesn't > really need to see.
Double prototypes seems to me like it's a cure worse than the disease to me... > Not worried either way, so I'll do as you suggest. +1. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
