Tom Lane wrote: > Peter Eisentraut <pete...@gmx.net> writes: > > On tis, 2011-11-29 at 16:32 -0500, Bruce Momjian wrote: > >> I have applied the attached patch to help make suggestsions for server > >> developers. I didn't reproduce most of the text because it was already > >> listed with the options. Let me know if you want additional text. > > > Advising "server developers" to use CFLAGS="-O0 -g", without > > qualification, is dangerous, in my mind, because that loses a lot of > > compiler checks. The only reason to use -O0 is when you really need to > > debug something in single steps and you can't make sense of it any other > > way. > > Yes. -O0 is really a pretty horrid default choice, and we should NOT be > recommending it, especially not with no discussion of the disadvantages.
I have applied the attached patch to mention the debugger. OK? -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +
commit 2ff36abeec948899b9a51d1c945e9fbe85e056d5 Author: Bruce Momjian <br...@momjian.us> Date: Tue Nov 29 19:11:53 2011 -0500 In docs, suggest "-O0 -g" only if using a debugger. diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml new file mode 100644 index 16fbdc6..76c64e5 *** a/doc/src/sgml/installation.sgml --- b/doc/src/sgml/installation.sgml *************** su - postgres *** 1418,1424 **** Server developers should consider using the configure options <option>--enable-cassert</> and <option>--enable-debug</> to enhance the ability to detect and debug server errors. They should also consider ! running configure with <literal>CFLAGS="-O0 -g"</>. </para> </note> </step> --- 1418,1424 ---- Server developers should consider using the configure options <option>--enable-cassert</> and <option>--enable-debug</> to enhance the ability to detect and debug server errors. They should also consider ! running configure with <literal>CFLAGS="-O0 -g"</> if using a debugger. </para> </note> </step>
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers