Simon Riggs <si...@2ndquadrant.com> writes: > The existing errmsg of "tablespace is not empty" doesn't cover all > reasons why tablespace was not removed.
Yeah, in fact that particular statement is really pretty bogus for the replay case, because as the comment says we know that the tablespace *is* empty so far as full-fledged database objects are concerned. > The final message should have > errmsg "tablespace not fully removed" > errhint "you should resolve this manually if it causes further problems" Planning to go with this: errmsg("directories for tablespace %u could not be removed", xlrec->ts_id), errhint("You can remove the directories manually if necessary."))); I thought about an errdetail, but the preceding LOG entries from destroy_tablespace_directories should provide the details reasonably well. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers