On 02/14/2012 05:39 PM, Tom Lane wrote:
OK, I fixed this up and committed it. I made some cosmetic changes (the most notable being that the definition of RowExpr is really changing here, and so should its comment). The adjust_appendrel_attrs situation was fixed by passing in the PlannerInfo, which is something that probably should have been made available all along --- there are very few nontrivial functions in the planner that don't need it.
Great, many thanks for finishing this up.
I'm still a bit annoyed by the behavior I mentioned here, http://archives.postgresql.org/pgsql-hackers/2011-11/msg01031.php that we don't get "real" column names from an unflattened VALUES RTE. Might be worth looking into that, but I don't have time for it.
A TODO maybe? cheers andrew -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers