Excerpts from Dimitri Fontaine's message of jue feb 16 14:42:26 -0300 2012: > Hi, > > Please find attached version 8 of the patch, which fixes most of your > complaints.
Hi, I didn't like the new cmdtrigger.h file. It's included by a lot of other headers, and it's also itself including execnodes.h and parsenodes.h which means practically the whole lot of the source tree is included in turn. If you could split it, so that the struct definition is in a different file that's only included by the few .c files that actually use that struct, I'd be much happier. ... after looking at it more closely, I think only this line needs to be in a separate file: typedef struct CommandContextData *CommandContext; and that file is included by other headers; they don't need the function declarations or the struct definition. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
