On Mon, Jan 16, 2012 at 02:03, Greg Smith <g...@2ndquadrant.com> wrote: > On 01/15/2012 12:20 PM, Tom Lane wrote: >> >> Please follow the style already used for system catalogs; ie I think >> there should be a summary table with one entry per view, and then a >> separate description and table-of-columns for each view. > > > Yes, that's a perfect precedent. I think the easiest path forward here is > to tweak the updated pg_stat_activity documentation, since that's being > refactoring first anyway. That can be reformatted until it looks just like > the system catalog documentation. And then once that's done, the rest of > them can be converted over to follow the same style. I'd be willing to work > on doing that in a way that improves what is documented, too. The > difficulty of working with the existing tables has been the deterrent for > improving that section to me.
I've applied a patch that does this now. Hopefully, I didn't create too many spelling errors or such :-) I also applied a separate patch that folded the list of functions into the list of views, since that's where they are called, as a way to reduce duplicate documentation. I did it as a spearate patch to make it easier to back out if people think that was a bad idea... I didn't add any new documentation at this point - I wanted to get this patch in before it starts conflicting with work others are potentially doing. I also noticed there were some stats functions that were undocumented - the view fields were listed, but not the functions themselves. I haven't added those either... -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (firstname.lastname@example.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers