Peter Eisentraut <pete...@gmx.net> writes: > Remove dead assignment > found by Coverity
init_sequence(seq_relid, &elm, &seq_rel); - seq = read_info(elm, seq_rel, &buf); + read_info(elm, seq_rel, &buf); I have to object to this patch. In the blind service of eliminating warnings from some tool or other, you will introduce warnings from other tools? It's traditional for lint to complain about code that sometimes ignores the return value of a function, for instance. I also do not think it does anything for readability for this call of read_info() to be unexpectedly unlike all the others. I think we should institute a project policy that we will ignore "dead assignment" coverity warnings. I have not seen one of those changes yet that seemed to me like a good idea. Any optimizing compiler is perfectly capable of figuring out that an assignment is dead and eliminating it, so there is no code size advantage from doing this manually; and even the gcc boys have not (yet?) decided they should warn about dead assignments. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers