On 03/28/2012 08:28 PM, Joachim Wieland wrote:
On Wed, Mar 28, 2012 at 5:19 PM, Andrew Dunstan<and...@dunslane.net> wrote:
First hurdle: It doesn't build under Windows/mingw-w64:
parallel.c:40:12: error: static declaration of 'pgpipe' follows
non-static declaration
Strange, I'm not seeing this but I'm building with VC2005. What
happens is that you're pulling in the pgpipe.h header. I have moved
these functions as static functions into pg_dump since you voted for
removing them from the other location (because as it turned out,
nobody else is currently using them).
But your patch hasn't got rid of them, and so it's declared twice. There
is no pgpipe.h, BTW, it's declared in port.h. If VC2005 doesn't complain
about the double declaration then that's a bug in the compiler, IMNSHO.
Doesn't it even issue a warning? I no longer use VC2005 for anything,
BTW, I use VC2008 or later.
Anyway, ISTM the best thing is just for us to get rid of pgpipe without
further ado. I'll try to get a patch together for that.
cheers
andrew
Joachim
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
