Tatsuo Ishii <is...@postgresql.org> writes:
> BTW, while editing the document, I noticed that pg_ctl.c's help
> message lacks some long options which are actually in the source code:
> '--timeout' and '--mode'.  Included is the proposed patch to fix the
> problem. If there's no objection, I would like to commit it. Comments?

I think this line needs some more thought:

> -     printf(_("  -m SHUTDOWN-MODE   can be \"smart\", \"fast\", or 
> \"immediate\"\n"));
> +     printf(_("  -m, --mode SHUTDOWN-MODE   can be \"smart\", \"fast\", or 
> \"immediate\"\n"));

because it's not respecting the intended alignment of the explanation
column.  (It wasn't before, either, but that's not an excuse to not fix
it.)  I think you could make it read just "-m, --mode MODE" and then
there would be room to align this switch's explanation with the ones
above it.  I'm tempted to also say that the explanation should be
        MODE can be \"smart\", \"fast\", or \"immediate\"

                        regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to