On 11 May 2012 19:45, Tom Lane <t...@sss.pgh.pa.us> wrote: > Andres Freund <and...@2ndquadrant.com> writes: >> Its the only place though which knows whether its actually sensible to wakeup >> the walsender. We could make it return whether it wrote anything and do the >> wakeup at the callers. I count 4 different callsites which would be an >> annoying duplication but I don't really see anything better right now. > > Another point here is that XLogWrite is not only normally called with > the lock held, but inside a critical section. I see no reason to take > the risk of doing signal sending inside critical sections. > > BTW, a depressingly large fraction of the existing calls to WalSndWakeup > are also inside critical sections, generally for no good reason that I > can see. For example, in EndPrepare(), why was the call placed where > it is and not down beside SyncRepWaitForLSN?
I think because nobody thought of that. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
