Excerpts from David E. Wheeler's message of lun jun 25 11:23:34 -0400 2012: > On Jun 25, 2012, at 3:35 PM, Tom Lane wrote: > > > +1 for the concept of turning warnings into errors, but is that really > > the cleanest, most idiomatic way to do so in Perl? Sheesh. > > It’s the most backward-compatible, but the most idiomatic way to do it > lexically is: > > use warnings 'FATAL'; > > However, that works only for the current lexical scope. If there are warnings > in the code you are calling from the current scope, the use of `local > $SIG{__WARN__}` is required.
So lets add 'FATAL' to the already existing "use warnings" lines in Catalog.pm and genbki.pl. I think the other files we should add this to are generate-errcodes.pl, generate-plerrorcodes.pl, generate-spiexceptions.pl, Gen_fmgrtab.pl. Maybe psql/create_help.pl too. We have a bunch of files in ECPG and MSVC areas and others in src/tools; not sure about those. We also have gen_qsort_tuple.pl which amusingly does not even use warnings. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers