Kohei KaiGai <kai...@kaigai.gr.jp> writes:
> 2012/7/3 Robert Haas <robertmh...@gmail.com>:
>> Why not just save and restore the user ID and security context
>> unconditionally, instead of doing this kind of dance?
>> 
>> +               if (portal->userId != GetUserId())
>> +                       SetUserIdAndSecContext(portal->userId, portal->secCo
>> +               else
>> +                       saveUserId = InvalidOid;
>> 
> In case when CurrentUserId was updated during the code block
> (E.g, execution of SET SESSION AUTHORIZATION), it overwrites
> this update on restoring user-id and security-context.

Um... what should happen if there was a SET SESSION AUTHORIZATION
to the portal's userId?  This test will think nothing happened.

                        regards, tom lane

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to