Excerpts from Peter Geoghegan's message of mar jul 10 15:54:59 -0400 2012: > On 10 July 2012 20:28, Alvaro Herrera <alvhe...@commandprompt.com> wrote:
> > FWIW about the new include: I feel a strong dislike about the forward > > declaration you suggest. Defining Relation in elog.h seems completely > > out of place. The one you suggested as precedent (BufFile) is > > completely unlike it, in that the declaration is clearly placed in the > > header (buffile.h) of the module that works with the struct in question. > > I haven't defined Relation in elog.h; I have pre-declared it there. > Maybe that isn't to your taste, but there is surely something to be > said for adding exactly one line of code in preference to adding an > entire new header file, and having a bunch of existing files include > that new header. That is true. I'd like to hear others' opinions. -- Álvaro Herrera <alvhe...@commandprompt.com> The PostgreSQL Company - Command Prompt, Inc. PostgreSQL Replication, Consulting, Custom Development, 24x7 support -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
