An EntpriseDB testing report indicated that pg_upgrade crashes if it
can't write into the current directory. This only happens in 9.2 and
head, so I have applied the attached patch to fix it.
--
Bruce Momjian <br...@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
diff --git a/contrib/pg_upgrade/util.c b/contrib/pg_upgrade/util.c
new file mode 100644
index 1c71204..2c0dfd6
*** a/contrib/pg_upgrade/util.c
--- b/contrib/pg_upgrade/util.c
*************** pg_log(eLogType type, char *fmt,...)
*** 78,84 ****
va_end(args);
/* PG_VERBOSE is only output in verbose mode */
! if (type != PG_VERBOSE || log_opts.verbose)
{
fwrite(message, strlen(message), 1, log_opts.internal);
/* if we are using OVERWRITE_MESSAGE, add newline to log file */
--- 78,85 ----
va_end(args);
/* PG_VERBOSE is only output in verbose mode */
! /* fopen() on log_opts.internal might have failed, so check it */
! if ((type != PG_VERBOSE || log_opts.verbose) && log_opts.internal != NULL)
{
fwrite(message, strlen(message), 1, log_opts.internal);
/* if we are using OVERWRITE_MESSAGE, add newline to log file */
-
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
