On Mon, Sep 3, 2012 at 10:07:43AM -0400, Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > Also, I don't see my doc addition on your patch; was that intentional? > > It's not necessary, no? The code now gets socket directory right > without help.
Well, the doc comment is: + If running check on an old pre-9.1 Unix-like running server, and the + old and new servers use different Unix-domain socket directories, + use the <option>-O</> option so the new server uses the same socket + directory as the old server, and set <envar>PGHOST</> similarly. Remember, we can't get the socket directory for pre-9.1 servers. When you and I added that for 9.1, we did it for pg_ctl, which was needed by pg_upgrade. We were not aware we would eventually be using it for pg_upgrade directly, but it is the logical progression of pg_ctl not working cleanly for non-standard socket and port numbers. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
