> > Currently lo_initialize() throws an error if one of oids are not > > available. I doubt we do the same way for 64-bit functions since this > > will make 9.3 libpq unable to access large objects stored in pre-9.2 > > PostgreSQL servers. > > > It seems to me the situation to split the case of pre-9.2 and post-9.3 > using a condition of "conn->sversion >= 90300". >
Agreed. I'll fix it like that. > > 4) src/test/examples/testlo64.c added for 64-bit API example(Yugo Nagata) > > > > Comments and suggestions are welcome. > > > miscellaneous comments are below. > > Regression test is helpful. Even though no need to try to create 4TB large > object, it is helpful to write some chunks around the design boundary. > Could you add some test cases that writes some chunks around 4TB offset. Agreed. I'll do that. > > Thanks, > -- > KaiGai Kohei <kai...@kaigai.gr.jp> > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers -- Yugo Nagata <nag...@sraoss.co.jp> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
