On Mon, Oct 8, 2012 at 12:12:54PM -0400, Tom Lane wrote: > Bruce Momjian <[email protected]> writes: > > I am seeing the following warnings in git head from zic.c: > > zic.c:1505: warning: ignoring return value of ‘fwrite’, declared with > > attribute warn_unused_result > > Yeah, this is probably a consequence of the _FORTIFY_SOURCE addition. > I believe that ratchets up warning pickiness as well as other things. > > I'm inclined to think we should make zic.c bail out on write errors. > Otherwise, "make install" could fail to notice an out-of-disk-space > situation during install. The analogy you are drawing to ignoring > errors while writing log messages is quite faulty. > > We're overdue for another round of syncing the tz code with upstream, > too. Might be best to do that first, just in case Olson's crew already > fixed this.
My warnings have disappeared now that _FORTIFY_SOURCE has been removed on Linux. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. + -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
