On 15 October 2012 20:04, Jeff Janes <jeff.ja...@gmail.com> wrote: > On Mon, Oct 15, 2012 at 11:49 AM, Andres Freund <and...@2ndquadrant.com> > wrote: >> On Monday, October 15, 2012 08:46:40 PM Jeff Janes wrote: >>> On Mon, Oct 15, 2012 at 11:14 AM, Josh Berkus <j...@agliodbs.com> wrote: >>> > I would be in favor of moving them to contrib for 9.4. Assuming that >>> > someone can figure out how this interacts with the existing system table >>> > opclasses. Them being in /contrib would also put less pressure on the >>> > next new hacker who decides to take them on as a feature; they can >>> > improve them incrementally without needing to fix 100% of issues in the >>> > first go. >>> >>> Is there anything currently in contrib that defines its own WAL >>> records and replay methods? Are there hooks for doing so? >> >> It's not really possible as rmgr.c declares a const array of resource >> managers. >> A contrib module can't sensibly add itself to that. I think changing this has >> been discussed/proposed in the past, but -hackers wasn't convinced... >> >> But then, the idea is to add it to -contrib while no WAL support exists.. > > Which then virtually guarantees that WAL support never will exist, doesn't it? > >> Personally I don't see a point in -contrib'ing it. I would rather see it >> throw >> errors in dangerous situations and be done with that. > > +1
All I'm planning to do for now is add docs and the WARNING suggested. -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
