From: pgsql-hackers-ow...@postgresql.org [pgsql-hackers-ow...@postgresql.org] on behalf of Amit kapila [amit.kap...@huawei.com] Sent: Monday, October 15, 2012 7:28 PM To: robertmh...@gmail.com; j...@agliodbs.com Cc: pgsql-hackers@postgresql.org Subject: [HACKERS] Re: patch submission: truncate trailing nulls from heap rows to reduce the size of the null bitmap [Review]
On Monday, October 15, 2012 7:28 PM Amit kapila wrote: On Saturday, October 13, 2012 1:24 PM Amit kapila wrote: Tue, 26 Jun 2012 17:04:42 -0400 Robert Haas wrote: >> I see you posted up a follow-up email asking Tom what he had in mind. >> Personally, I don't think this needs incredibly complicated testing. >> I think you should just test a workload involving inserting and/or >> updating rows with lots of trailing NULL columns, and then another >> workload with a table of similar width that... doesn't. If we can't >> find a regression - or, better, we find a win in one or both cases - >> then I think we're done here. >As per the last discussion for this patch, performance data needs to be >provided before this patch's Review can proceed >further. >So as per your suggestion and from the discussions about this patch, I have >collected the performance data as below: >Results are taken with following configuration. >1. Schema - UNLOGGED TABLE with 2,000,000 records having all columns are INT >type. >2. shared_buffers = 10GB >3. All the performance result are taken with single connection. >4. Performance is collected for INSERT operation (insert into temptable select >* from inittable) >Platform details: > Operating System: Suse-Linux 10.2 x86_64 > Hardware : 4 core (Intel(R) Xeon(R) CPU L5408 @ 2.13GHz) > RAM : 24GB > Further to Performance data, I have completed the review of the Patch. Please find the patch to address Review Comments attached with this mail. IMO, now its ready for a committer. With Regards, Amit Kapila.
Truncate-trailing-null-columns-from-heap-rows.v2.patch
Description: Truncate-trailing-null-columns-from-heap-rows.v2.patch
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
