Hello a some updated version
* possibility to raise (and filter) performance warnings - detects IO castings * detects assign composite value to scalar variable Regards Pavel Stehule 2012/11/27 Pavel Stehule <pavel.steh...@gmail.com>: > Hello > > I am sending a updated version - now it is prepared for event triggers > and it is little bit more robust > > I run pgindent, but I have no experience with it, so I am not sure about > success > > Regards > > Pavel Stehule > > > 2012/10/7 Selena Deckelmann <sel...@chesnok.com>: >> Hi! >> >> On Tue, Jun 26, 2012 at 1:19 AM, Pavel Stehule <pavel.steh...@gmail.com> >> wrote: >> >>> I am sending lightly refreshed patch for checking plpgsql functions.. >>> >>> I checked different implementation, but without success: a) enhancing >>> of SPI to some fake mode can has negative impact on application, and >>> patch was not clear, b) generic plpgsql walker doesn't save lines too. >>> >>> I invite any ideas how to improve this patch >> >> I reviewed this and did a clean up for bitrot and a little whitespace. >> In particular, it needed to learn a little about event triggers. >> >> This patch is a follow on from an earlier review thread I found: >> http://archives.postgresql.org/message-id/d960cb61b694cf459dcfb4b0128514c2072df...@exadv11.host.magwien.gv.at >> >> I dug through that thread a bit, and I believe issues raised by >> Laurenz, Petr and Alvaro were resolved by Pavel over time. >> >> All tests pass, and after a read-through, the code seems fine. >> >> This also represents my inaugural use of pg_bsd_indent. I ran it on >> pl_check.c - which made things mostly better. Happy to try and fix it >> up more if someone can explain to me what (if anything) I did >> incorrectly when using it. >> >> -selena >> >> -- >> http://chesnok.com
plpgsql_check_function_20121128_01.patch.gz
Description: GNU Zip compressed data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
