On 2012-11-30 12:50:06 +0000, Simon Riggs wrote: > On 30 November 2012 11:58, Andres Freund <and...@2ndquadrant.com> wrote: > > > We only get the pin right there, I don't see any preexisting pin. > > Seems easy enough to test with an Assert patch. > > If the Assert doesn't fail, we apply it as "documentation" of the > requirement for a pin. > > If it fails, we fix the bug.
I think its wrong even if we were holding a pin all the time due the the aforementioned PageAddItem reshuffling of line pointers. So that Assert wouldn't proof enough. I can try to proof corruption there, but I would rather see somebody coming along telling me why its safe and that I am dumb for not realizing it. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
