Hi, The xlog_fn.h patch was Alvaro's idea (and patch) btw, I previously had used an ugly typedef for Datum to get arround defining FRONTEND/including postgres.h...
On 2012-12-10 19:56:49 +0200, Heikki Linnakangas wrote: > We still need the "#define FRONTEND 1" ugly hack in pg_controldata and > pg_resetxlog with this, but we get rid of it in pg_basebackup. I think > that's reasonable, pg_controldata and pg_resetxlog are more low-level > programs than pg_basebackup. It's also for the pg_receivellog introduced in one of my other patches... So it seems to be a good idea to me. > The name xlog_internal.h is a bit of a misnomer now, it's > not very internal anymore, if it can now actually be included by external > programs. But the point is that the file contains declarations related to > the WAL file format. We could rename it to xlog_details.h or such, but I guess the noise would outhweigh the benefits. > Any objections? Unsurprisingly none from my side. Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
