2012/12/17 Shigeru Hanada <shigeru.han...@gmail.com>:
> On Sun, Oct 28, 2012 at 7:16 AM, Pavel Stehule <pavel.steh...@gmail.com> 
> wrote:
>> Hello
>> here is updated patch
>> main change - it doesn't touch psql lexer - like Tom proposed
>> other points respect Phil's notices
> I reviewed v12 patch.  It provides gset command which works
> consistently with other psql commands, such as \g and \set, and
> implementation seems reasonable, and follows other reviewer's comments
> properly.  I think we can mark it as "ready for committer", once you
> have fixed some minor issues below.
> * Skipping leading blank in inner while loop of command.c seems
> unnecessary, because (IIUC) psql's scanner skips blanks.  Is there any
> case that scanner returns token with leading/trailing blank?


> * ISTM that VARLIST_INITIAL can be removed.  AFAIS it's same state as


> * I found some cosmetic flaw and typo.  Please see attached patch for details.

it is ok, merged

> * How about pulling up codes for PGRES_TUPLES_OK case in
> StoreQueryResult to new static function, say StoreQueryTuple?  It
> would make StoreQueryResult more similar to PrintQueryResult's style,
> and IMO it makes the code more readable.

good idea

Attached updated patch



> Regards,
> --
> Shigeru HANADA

Attachment: gset_13.diff
Description: Binary data

Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:

Reply via email to