Looks good to me. Will mark "Ready for Committer"
Thanks On Thu, Dec 20, 2012 at 2:30 AM, Tomas Vondra <t...@fuzzy.cz> wrote: > On 19.12.2012 06:30, Jeevan Chalke wrote: > > > > > > > > On Mon, Dec 17, 2012 at 5:37 AM, Tomas Vondra <t...@fuzzy.cz > > <mailto:t...@fuzzy.cz>> wrote: > > > > Hi, > > > > attached is a new version of the patch that > > > > (a) converts the 'log_step_seconds' variable to a constant (and does > > not allow changing it using a command-line option etc.) > > > > (b) keeps the current logging as a default > > > > (c) adds a "-q" switch that enables the new logging with a 5-second > > interval > > > > I'm still not convinced there should be yet another know for tuning > the > > log interval - opinions? > > > > > > It seems that you have generated a patch over your earlier version and > > due to that it is not cleanly applying on fresh sources. > > Please generate patch on fresh sources. > > Seems you're right - I've attached the proper patch against current master. > > > However, I absolutely no issues with the design. Also code review is > > already done and looks good to me. > > I think to move forward on this we need someone from core-team. So I am > > planning to change its status to "ready-for-committor". > > > > Before that please provide updated patch for final code review. > > thanks > Tomas > > > -- > Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgsql-hackers > > -- Jeevan B Chalke Senior Software Engineer, R&D EnterpriseDB Corporation The Enterprise PostgreSQL Company Phone: +91 20 30589500 Website: www.enterprisedb.com EnterpriseDB Blog: http://blogs.enterprisedb.com/ Follow us on Twitter: http://www.twitter.com/enterprisedb This e-mail message (and any attachment) is intended for the use of the individual or entity to whom it is addressed. This message contains information from EnterpriseDB Corporation that may be privileged, confidential, or exempt from disclosure under applicable law. If you are not the intended recipient or authorized to receive this for the intended recipient, any use, dissemination, distribution, retention, archiving, or copying of this communication is strictly prohibited. If you have received this e-mail in error, please notify the sender immediately by reply e-mail and delete this message.
