Hello
2012/12/31 Stephen Frost <sfr...@snowman.net>:
> Pavel,
>
> * Pavel Stehule (pavel.steh...@gmail.com) wrote:
>> I found one issue - if I disallow mixing positional and ordered style
>> I break compatibility with previous implementation.
>
> Can you elaborate? In the previous example, an error was returned when
> mixing (not a terribly good one, but still an error). Returning a
> better error won't be a problem.
A result from ours previous talk was a completely disabling mixing
positional and ordered placeholders - like is requested by man and gcc
raises warnings there.
But mixing is not explicitly disallowed in doc, and mixing was tested
in our regress tests. There are tests where placeholders are mixed -
so anybody can use it.
select format('Hello %s %1$s %s', 'World', 'Hello again'); -- is
enabled and supported and result is expected
-- but this raises error - and it is same situation like previous example
select format('%s %2$s %s', 'Hello', 'World');
-- so bot examples should be executed or should be disabled if this
functionality should be consistent. And I can't to break first
example, then I have to repair second example
Regards
>
>> so maybe third way is better - use fix from my patch - a behave is
>> same like in glibc - and raise warning (instead errors) when mixing
>> styles is detected - we can replace warnings by errors in future.
>>
>> What do you think?
>
> If there are cases which work today then I agree that we should issue a
> warning to avoid breaking existing applications. We should still use
> the glibc format when adding width support, however.
>
> Thanks,
>
> Stephen
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
