Alvaro Herrera wrote: > Andres Freund wrote: > > On 2013-01-18 15:48:01 +0100, Andres Freund wrote: > > > Here's a trivially updated patch which also defines AssertArg() for > > > FRONTEND-ish environments since Alvaro added one in xlogreader.c. > > > > This time for real. Please. > > Here's a different idea: move all the Assert() and StaticAssert() etc > definitions from c.h and postgres.h into a new header, say pgassert.h. > That header is included directly by postgres.h (just like palloc.h and > elog.h already are) so we don't have to touch the backend code at all. > Frontend programs that want that functionality can just #include > "pgassert.h" by themselves. The definitions are (obviously) protected > by #ifdef FRONTEND so that it all works in both environments cleanly.
One slight problem with this is the common port/*.c idiom would require an extra include: #ifndef FRONTEND #include "postgres.h" #else #include "postgres_fe.h" #include "pgassert.h" /* <--- new line required here */ #endif /* FRONTEND */ If this is seen as a serious issue (I don't think so) then we would have to include pgassert.h into postgres_fe.h which would make the whole thing pointless (i.e. the same as just having the definitions in c.h). -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
