Hello 2013/1/29 Dean Rasheed <dean.a.rash...@gmail.com>: > On 29 January 2013 08:19, Dean Rasheed <dean.a.rash...@gmail.com> wrote: >> * The width field is optional, even if the '-' flag is specified. So >> '%-s' is perfectly legal and should be interpreted as '%s'. The >> current implementation treats it as a width of 0, which is wrong. >> > > Oh, but of course a width of 0 is the same as no width at all, so the > current code is correct after all. That's what happens if I try to > write emails before I've had my caffeine :-) > > I think my other points remain valid though. It would still be neater > to parse the flags separately from the width field, and then all > literal numbers that appear in the format should be positive.
I am sending rewritten code
It indirect width "*" and "*n$" is supported. It needs little bit more code.
There are a new question
what should be result of
format(">>%2$*1$s<<", NULL, "hello")
???
raise exception now, but I am able to modify to some agreement
Regards
Pavel
>
> Regards,
> Dean
format_width_20130131.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
