Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> >     else if (*s == 0)
> > !           elog(ERROR, "pg_atoi: zero-length string!");
> 
> The exclamation point seems inappropriate.  Perhaps "zero-length input"
> would be better than "string" also.

I copied the other test case:

    if (s == (char *) NULL)
        elog(ERROR, "pg_atoi: NULL pointer!"); 

I removed them both '!'.

> Otherwise this seems like a reasonable thing to do.

OK, will apply now.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  [EMAIL PROTECTED]               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe-nomail command to [EMAIL PROTECTED] so that your
message can get through to the mailing list cleanly

Reply via email to