On Sun, Feb 17, 2013 at 4:26 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > No, it'd be more like a micro-pessimization, because the test would be > wasted effort in the vast majority of calls. The *only* reason to do > this would be to shut up valgrind, and that seems annoying.
In terms of runtime I strongly suspect the effect would be 0 due to branch prediction. The effect on the code cleanliness seems like a stronger argument but I have a hard time getting upset about a single one-line if statement in namestrcpy. I suspect the argument may have been that we have no reason to believe namestrcpy is the only place this can happen. -- greg -- Sent via pgsql-hackers mailing list (email@example.com) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers