On Fri, Mar 8, 2013 at 2:23 AM, Pavel Stehule <[email protected]> wrote: > 2013/3/8 Josh Kupershmidt <[email protected]>:
>> Cool. I think it would also be useful to check that --clean may only >> be used with --format=p to avoid any confusion there. (This issue >> could be addressed in a separate patch if you'd rather not lard this >> patch.) > > no > > some people - like we in our company would to use this feature for > quiet and strict mode for plain text format too. > > enabling this feature has zero overhead so there are no reason block > it anywhere. I'm not sure I understand what you're getting at, but maybe my proposal wasn't so clear. Right now, you can specify --clean along with -Fc to pg_dump, and pg_dump will not complain even though this combination is nonsense. I am proposing that pg_dump error out in this case, i.e. $ pg_dump -Fc --file=test.dump --clean -d test pg_dump: option --clean only valid with plain format dump Although this lack of an error a (IMO) misfeature of existing pg_dump, so if you'd rather leave this issue aside for your patch, that is fine. Josh -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
