Hadi Moshayedi <h...@moshayedi.net> wrote: > I updated the patch by taking ideas from your patch, and unifying > the transition struct and update function for different > aggregates. The speed of avg improved even more. It now has 60% > better performance than the current committed version.
Outstanding! > I also noticed that this patch makes matview test fail. It seems > that it just changes the ordering of rows for queries like > "SELECT * FROM tv;". Does this seem like a bug in my patch, or > should we add "ORDER BY" clauses to this test to make it more > deterministic? I added some ORDER BY clauses. That is probably a good thing anyway for purposes of code coverage. Does that fix it for you? -- Kevin Grittner EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
