Robert Haas escribió:

> I think this patch as currently written is going to leave us with the
> following dubious-looking construct.
> 
>               if (!ConditionalLockBufferForCleanup(buf))
>               {
>                       if (!ConditionalLockBufferForCleanup(buf))
>                       {
> 
> Modulo that minor gripe, I think it's definitely worth doing this in
> master.  I'm a bit disinclined to change the message string in 9.2,
> and therefore might not back-patch at all, since there's basically no
> consequence to this except for mildly inaccurate reporting.  But if
> people feel it's worth a translation break for this, I don't object to
> back-patching it either.

We break translations to fix bugs from time to time.  Translators do
update for minor releases, so if this is the only consideration, I don't
think we should hold this bugfix for it (or any other, IMV).

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to