On Wed, Jun 26, 2013 at 2:36 PM, Hari Babu <haribabu.ko...@huawei.com> wrote: > On June 26, 2013 5:02 AM Josh Kupershmidt wrote: >>Thanks for the feedback. Attached is a rebased version of the patch with > the two small issues noted fixed.
The following description in the document of pg_ctl needs to be modified? restart might fail if relative paths specified were specified on the command-line during server start. +#define DATADIR_SPEC "\"-D\" \"" + + datadir = strstr(post_opts, DATADIR_SPEC); Though this is a corner case, the patch doesn't seem to handle properly the case where "-D" appears as other option value, e.g., -k option value, in postmaster.opts file. Just idea to work around that problem is to just append the specified -D option and value to post_opts. IOW, -D option and value appear twice in post_opts. In this case, posteriorly-located ones are used in the end. Thought? Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers