Bruce Momjian <br...@momjian.us> writes:
> Should we be using entab -s 3?
IIUC, that wouldn't affect leading whitespace at all. What it would
affect I think (outside of comment blocks) is whitespace between code
and a same-line /* ... */ comment. Personally I'd prefer that a
tab-stop-aligned /* ... */ comment always have a tab before it, even
if the expansion of the tab is only *one* space. That is, in
foo(bar, /* comment */
bar1, /* comment */
bar12, /* comment */
bar123, /* comment */
baz); /* comment */
I think each of those comments ought to have a tab before it, not
space(s). pgindent currently does this inconsistently --- the bar123
line will have a space instead. Moving to -s 3 would presumably make
this worse (even less consistent) not better, since now the bar12 line
would also be emitted with spaces not a tab.
Inside a comment, though, probably the behavior of -s 3 would be just
fine. So the real problem here IMO is that use of tabs ought to be
context sensitive (behavior inside a comment different from outside),
and I don't think entab can do that. I see though that it understands
about C quoted strings, so maybe we could teach it about comments too?
No idea whether astyle is any smarter about this.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
