On Tue, Jul 2, 2013 at 1:43 AM, Bruce Momjian <br...@momjian.us> wrote: > Agreed --- attached patch applied. I also noticed that we sometimes > test for -? then --help, but other times do things in the opposite > order, and the same for -V/--version, so I made that consistent. > > However, I also noticed that while we document -? before --help, we test > for --help before -?, and the same for -V/--version. Should I make > those even more consistent by always testing for the single-letter > option first? I am not sure if this is worth doing for all the binaries, the output result and the return code being the same in all the cases. Having an undocumented -h was somehow different because it caused the spec of pg_ctl and friends to behave differently than what was documented. My 2c. -- Michael
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
