On Sat, Jul 06, 2013 at 11:49:21AM +0100, Dean Rasheed wrote: > On 5 July 2013 18:23, David Fetter <[email protected]> wrote: > > Please find attached changes based on the above. > > > > This looks good. The grammar changes are smaller and neater now on top > of the makeFuncCall() patch. > > Overall I think this patch offers useful additional functionality, in > compliance with the SQL spec, which should be handy to simplify > complex grouping queries. > > There's a minor typo in syntax.sgml: "for each input row, each row > matching same." --- fix attached.
That is actually correct grammar, but may not be the easiest to translate. > I think this is ready for committer. Thanks :) Cheers, David. -- David Fetter <[email protected]> http://fetter.org/ Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter Skype: davidfetter XMPP: [email protected] iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate -- Sent via pgsql-hackers mailing list ([email protected]) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
