Il 7/25/2013 11:02 PM, Alvaro Herrera ha scritto:
Andrew Dunstan wrote:
Jeff Janes asked me about this, and Bruce just tripped up on it.
Usually on Windows it's necessary to have libpq.dll/cygpq.dll either
in the PATH or in the same directory as client .exe files. The
buildfarm client has for many years simply copied this dll from the
installation lib to the installation bin directory after running
"make install". But I can't really see why we don't do that as part
of "make install" anyway. I haven't tested but I think something
like this patch would achieve this goal - it would fix something
that's tripped a lot of people up over the years.
Seems a reasonable workaround for a silly platform bug. Do you need to
patch the MSVC stuff as well?
Comments? If we do this, should it be backported?
To 9.3, sure, but not further back, as there's probably little point.
on cygwin no need to go before 9.3 .
We already moved them during the package build as workaround.
+ifneq (,$findstring($(PORTNAME), win32 cygwin))
+ $(INSTALL_DATA) $(shlib) '$(DESTDIR)$(bindir)/$(shlib)'
+endif
I wonder if someday we will create a win64 $(PORTNAME) value, or
something like that, and then we'll have to update the port list on
which these hacks are applied all over the place. Not complaining
about this patch in particular, just an idle thought.
Andrew,
are you planning to include also
http://www.postgresql.org/message-id/e1uqoyt-0007qc...@wrigleys.postgresql.org
http://www.postgresql.org/message-id/51b59794.3000...@gmail.com
to get rid of dllwrap ?
Regards
Marco
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
